T006: Parent trust walk — skip writes when parent trusted#18
Merged
Conversation
Claude Code walks parent directories when checking trust. Updated ensure_workspace_trusted() to check ancestors before writing, avoiding unnecessary per-project entries when a parent dir is already trusted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_workspace_trusted()now walks parent directories before writing to~/.claude.jsonhasTrustDialogAccepted: true, the child is already covered — no write needed~/.claude.jsonbloat: one trusted parent dir replaces dozens of per-project entriesTest plan
python scripts/test.py— 70 passed, 0 failedbash scripts/test/test-T006-parent-trust.sh— parent walk logic verifiedProjectsCL1parent trust to~/.claude.json— all child projects auto-trusted